JazzJackrabbit Community Forums - Should J2O reupload fixed versions of broken scripts?

JazzJackrabbit Community Forums (http://www.jazz2online.com/jcf/index.php)

- JCS & Scripting (http://www.jazz2online.com/jcf/forumdisplay.php?f=5)

- - Should J2O reupload fixed versions of broken scripts? (http://www.jazz2online.com/jcf/showthread.php?t=20799)

Should J2O reupload fixed versions of broken scripts?

From time to time, JJ2+ updates to a new version of AngelScript, and a handful of existing scripts can end up breaking as a result. In such cases, if the original authors can't be contacted, should J2O mods/admins reupload those existing scripts so that they can be played again?

For example, Psychomondus straight-up does not compile anymore: the author tried to do something that was never worked to begin with, and at some point AngelScript updated to treat that as a syntax error. The author was last online in November 2022. Should J2O reupload it? Or is that an infringement on the author's rights?

Are there other examples out there besides Psychomondus? Does the number of such uploads, or their popularity, affect the decision? Or how much time has passed since the original upload?

What about (parts of) levels that never worked to begin with, even for reasons other than AngelScript?

I also found one level where AngelScript won't work:

https://www.jazz2online.com/download...ayer-level-ii/

A Generic Single Player Level II

Maybe there will be a solution to fix it.

.
bevore many years, i had in mind to ask the community for help.
i saw the same problem, and ye i do have a script, that lost his compatility
.
to the story:
it was 2013, when i played with zepect, a script that was made by Foly
zepect showed it me, this script changed a few weapons
for example, the seecers, was different, here we saw a purple, bollyship missile
and when the missile exploded, there was a fire ring arround it
and that fire did gone from the center in form of a ring outside
.
i do have a screenshots from that script in action:

.
as i allready told that script dont works anymore, and lost his compatility.
.
here you go:
http://www.niceclan.de/dev/z/temporary/folta/
.
code:

Code:

/***************************************************/

/**        Made by Foly                                                                    **/

/**        Feel free to use/copy any part of this script **/

/***************************************************/



/***Constants***/



//Bomb Constants

const float cBombSpeed = 8; //xSpeed of the bomb

const float cBombPlayerSpeed = 6; //xSpeed the bomb can gain by player speed (if a player is running full speed it will add 6 xSpeed)

const int cBombLifeTime = 70*2; //Time till the bomb explodes (run away! run away!!!1)



//Shard Trail Constants

const int cSpreadSpeed = 2; //The higher this value the more the shards will spread perpendicular to the blasterbullet

const float cSlowDownSpeed = 6; //How much the shards slow down compared to the bullet

const int cTrailLifeTime= 70*1.5; //How long the shards will exist

const int cGreenDensityFactor = 6; //A lower factor gives more green shards

const int cBlueDensityFactor = 4; //A lower factor gives more blue shards



//Heavy Bomb Constants

const float cRadiusXFactor = 1.0;

const float cRadiusYFactor = 0.95;

const float cRadiusXSpdFactor = 1.0;

const float cRadiusYSpdFactor = 1.3;



//Boomerang gun constants

const float cMaxSpeed = 10; //The maximum speed the boomerang can have

const float cAcceleration = 0.2; //The acceleration of the boomerang

const float cReturnAccMult = 1; //When the boomerang is returning, this is a multiplier for the acceleration (so a value of 2 let's the boomerang return with 2x acceleration)

const float cVerSpdMult = 0.7; //When the boomerang is shot vertical and not returning, this is a multiplier for the acceleration (a higher value lets the boomerang go faster and higher upward)

const float cReturnSpeed = 0.4; //At what speed the boomerang returns back to the player (WARNING! This constant should always be higher than cAcceleration)

const float cReturnRadius = 32; //Radius in pixels at which the player takes the boomerang back



//Ice slow constants

const int cSlowTime = 18*5;





/***Variables***/

int FreezeTime = 0;



//Boomerang gun variables

array returning(32, false);

array boomerangfired(32, false);

array speed(32, cMaxSpeed);

array isfoly(32, false);



/***Math functions***/

//Calculates the distance between two points

float distance(float x1, float y1, float x2, float y2) {

  return sqrt((x2 - x1)*(x2 - x1) + (y2 - y1)*(y2 - y1));

}

 

//The square root function

float sqrt(float x) {

  float y = 1.0;

  for (int i = 0; i < 20; i++)

    y = (y + x/y)/2;

  return y;

}

 

//Determines the absolute value

float abs(float x) {

  if (x < 0)

    x = -x;

  return x;

}



/***Other functions***/

void CreateBomb(int objectID) {

        int playerID = jjObjects[objectID].creator - 32768;

        int bombID = jjAddObject(OBJECT::APPLE, jjPlayers[playerID].xPos, jjPlayers[playerID].yPos, jjObjects[objectID].creator, CREATOR::PLAYER);

        jjObjects[bombID].objType = 3;

        jjObjects[bombID].determineCurAnim(ANIM::AMMO, 1, true);

        jjObjects[bombID].special = 11;

        jjObjects[bombID].xSpeed = cBombSpeed*jjPlayers[playerID].direction + cBombPlayerSpeed*jjPlayers[playerID].xSpeed/16;

        jjObjects[bombID].ySpeed = -3;

        //jjSample(jjObjects[Bullet].xPos, jjObjects[Bullet].yPos, SOUND::BONUS_BONUS1); For some reason my sounds never seem to work :[

}



void DestroyBomb(int bombID) {

        int explosionID = jjAddObject(OBJECT::TNT, jjObjects[bombID].xPos, jjObjects[bombID].yPos, jjObjects[bombID].creator, CREATOR::PLAYER);

        jjDeleteObject(bombID);

        jjObjects[explosionID].determineCurAnim(ANIM::AMMO, 1, true);

        jjObjects[explosionID].killAnim = ANIM::AMMO;

        jjObjects[explosionID].state = STATE::EXPLODE;

        //jjSample(jjObjects[Bullet].xPos, jjObjects[Bullet].yPos, SOUND::COMMON_EXPSM1);

}



void CreateBigRocket(int objectID, bool powerup) {

        int rocketID;

        int playerID = jjObjects[objectID].creator - 32768;

        if (powerup)

                rocketID = jjAddObject(OBJECT::RFBULLETPU, jjPlayers[playerID].xPos, jjPlayers[playerID].yPos, jjObjects[objectID].creator, CREATOR::PLAYER);

        else

                rocketID = jjAddObject(OBJECT::RFBULLET, jjPlayers[playerID].xPos, jjPlayers[playerID].yPos, jjObjects[objectID].creator, CREATOR::PLAYER);

        jjObjects[rocketID].determineCurAnim(ANIM::SONCSHIP, 0, true);

        jjObjects[rocketID].special = 13;

        jjObjects[rocketID].direction = jjPlayers[playerID].direction;

        jjObjects[rocketID].xAcc = 0;

        jjObjects[rocketID].xSpeed = 3*jjPlayers[playerID].direction + 2*jjPlayers[playerID].xSpeed/16;

        jjObjects[rocketID].counterEnd = 70;

}



void BigRocketExplode(int rocketID, bool powerup) {

        int toasterID;

        jjObjects[rocketID].special = 14;

        for (int i = 0; i < 14; i++) {

                if (powerup)

                        toasterID = jjAddObject(OBJECT::TOASTERBULLETPU, jjObjects[rocketID].xPos + 64*cRadiusXFactor*jjCos(i*1023/13), jjObjects[rocketID].yPos + 64*cRadiusYFactor*jjSin(i*1023/13), jjObjects[rocketID].creator, CREATOR::PLAYER);

                else

                        toasterID = jjAddObject(OBJECT::TOASTERBULLET, jjObjects[rocketID].xPos + -16*cRadiusXFactor*jjCos(i*1023/13), jjObjects[rocketID].yPos + -16*cRadiusYFactor*jjSin(i*1023/13), jjObjects[rocketID].creator, CREATOR::PLAYER);

                jjObjects[toasterID].counter = 40; //You wouldn't believe what kind of bug comes up when you remove this line...

                jjObjects[toasterID].xAcc = 0;

                jjObjects[toasterID].xSpeed = -cRadiusXSpdFactor*jjCos(i*1023/13);

                jjObjects[toasterID].ySpeed = -cRadiusYSpdFactor*jjSin(i*1023/13);

        }

}



void CreateShardTrail(int bulletID, bool greentrail) {

        int shardID = jjAddObject(OBJECT::SHARD, jjObjects[bulletID].xPos, jjObjects[bulletID].yPos, 0, CREATOR::PLAYER);

        jjObjects[shardID].special = 12;

        if (greentrail)

                jjObjectPresets[OBJECT::SHARD].determineCurAnim(ANIM::PICKUPS, 6+jjRandom()%4, true);

        else

                jjObjectPresets[OBJECT::SHARD].determineCurAnim(ANIM::PICKUPS, 44+jjRandom()%4, true);

        if (jjObjects[bulletID].direction != 0) {

                jjObjects[shardID].xSpeed = jjObjects[bulletID].xSpeed - jjObjects[bulletID].direction*cSlowDownSpeed;

                jjObjects[shardID].ySpeed = -cSpreadSpeed*(jjRandom()%32 - 16)/16;

        } else {

                jjObjects[shardID].xSpeed = -cSpreadSpeed*(jjRandom()%32 - 16)/16;

                jjObjects[shardID].ySpeed = jjObjects[bulletID].ySpeed + cSlowDownSpeed;

        }

}



void BoomerangGun(int boomerangID) {

        int playerID = jjObjects[boomerangID].creator - 32768;;



        if ((abs(jjObjects[boomerangID].xSpeed) < cReturnSpeed && jjObjects[boomerangID].direction != 0) || (abs(jjObjects[boomerangID].ySpeed) < cReturnSpeed && jjObjects[boomerangID].direction == 0) && !returning[playerID])

                returning[playerID] = true;



        if (jjObjects[boomerangID].counter == 1) {

                if (playerID == p.playerID)

                        p.noFire = true;

                jjObjects[boomerangID].determineCurAnim(ANIM::TUFBOSS, 3);

                jjObjects[boomerangID].counterEnd = 254;

        }



        if (returning[playerID]) {

                if (distance(jjPlayers[playerID].xPos, jjPlayers[playerID].yPos, jjObjects[boomerangID].xPos, jjObjects[boomerangID].yPos) < cReturnRadius)

                        jjKillObject(boomerangID);

                

                if (speed[playerID] < cMaxSpeed)

                        speed[playerID] = speed[playerID] + cAcceleration*cReturnAccMult;



                jjObjects[boomerangID].ySpeed = speed[playerID]*(jjPlayers[playerID].yPos - jjObjects[boomerangID].yPos)/distance(jjPlayers[playerID].xPos, jjPlayers[playerID].yPos, jjObjects[boomerangID].xPos, jjObjects[boomerangID].yPos);

                jjObjects[boomerangID].xSpeed = speed[playerID]*(jjPlayers[playerID].xPos - jjObjects[boomerangID].xPos)/distance(jjPlayers[playerID].xPos, jjPlayers[playerID].yPos, jjObjects[boomerangID].xPos, jjObjects[boomerangID].yPos);

        } else {

                if (speed[playerID] > 0)

                        speed[playerID] = speed[playerID] - cAcceleration;

                if (jjObjects[boomerangID].direction == 0)

                        jjObjects[boomerangID].ySpeed = -speed[playerID]*cVerSpdMult;

                else

                        jjObjects[boomerangID].xSpeed = speed[playerID]*jjObjects[boomerangID].direction;

        }



        if (jjObjects[boomerangID].counter > 200)

                jjObjects[boomerangID].counter = 30;

}



/***onFunctions***/





/***Gameplay functions***/

void onLevelLoad() {

        jjAlert("||No errors in da codez");

}



void onMain() {

        /*if (jjIsServer) {

                for (int i = 0; i < 32; i++) {

                        if (jjPlayers[i].isActive && !isfoly[i]) {

                                isfoly[i] = true;

                                jjChat("/rename " + i + " Foly");

                        } else

                        if (!jjPlayers[i].isActive)

                                isfoly[i] = false;

                }

        }

        /*if (jjGameTicks%4 == 0 && FreezeTime > 0) {

                if (p.health == 0)

                        FreezeTime = 1;

                if (FreezeTime == 1)

                        p.jumpStrength = -10;

                FreezeTime--;

                if (p.xSpeed*p.xSpeed > 3.5*3.5)

                        p.xSpeed = p.direction*4;

                j = jjAddObject(OBJECT::SHARD, p.xPos, p.yPos);

                jjObjectPresets[OBJECT::SHARD].determineCurAnim(ANIM::COMMON, 2, true);

                jjObjects[j].xSpeed = -4*(jjRandom()%32 - 16)/16;

                jjObjects[j].ySpeed = -4*(jjRandom()%32 - 16)/16;

                jjObjects[j].special = 43;

        }

        

        if (p.frozen > 0) {

                FreezeTime = cSlowTime;

                p.freeze(false);

                p.jumpStrength = -7;

        }*/

        

        for (int i = 0;        i < jjObjectCount; i++)

                if (jjObjects[i].isActive && jjObjects[i].creatorType == CREATOR::PLAYER) {



                        //Maintain boomerang gun

                        if (jjObjects[i].eventID == OBJECT::BLASTERBULLETPU) {

                                BoomerangGun(i);

                                jjObjects[i].animSpeed = 3;

                                boomerangfired[jjObjects[i].creator - 32768] = true;

                                continue;

                        }

                        

                        //Create bomb

                        if (jjObjects[i].eventID == OBJECT::TNT && jjObjects[i].state != STATE::EXPLODE) {

                                CreateBomb(i);

                                jjDeleteObject(i);

                                continue;

                        }

                

                        //Destroy bomb

                        if (jjObjects[i].eventID == OBJECT::APPLE && jjObjects[i].special == 11) {

                                jjObjects[i].age++;

                                if (jjObjects[i].age > cBombLifeTime)

                                        DestroyBomb(i);

                                continue;

                        }



                        //Shard Trail

                        if (((jjGameTicks%cBlueDensityFactor == 0 && (jjObjects[i].eventID == OBJECT::ICEBULLET || jjObjects[i].eventID == OBJECT::ICEBULLETPU)) || (jjGameTicks%cGreenDensityFactor == 0 && jjObjects[i].eventID == OBJECT::BLASTERBULLET)) && jjObjects[i].state != STATE::EXPLODE) {

                                CreateShardTrail(i, (jjObjects[i].eventID == OBJECT::BLASTERBULLET));

                                continue;

                        }

        

                        //Maintain shard lifetime

                        if (jjObjects[i].eventID == OBJECT::SHARD && jjObjects[i].special == 12) {

                                jjObjects[i].age++;

                                if (jjObjects[i].age > cTrailLifeTime)

                                        jjDeleteObject(i); 

                                continue;

                        }

                        

                        //Create big rocket

                        if (jjObjects[i].eventID == OBJECT::SEEKERBULLET || jjObjects[i].eventID == OBJECT::SEEKERBULLETPU) {

                                CreateBigRocket(i, (jjObjects[i].eventID == OBJECT::SEEKERBULLETPU));

                                jjDeleteObject(i);

                                continue;

                        }

                        

                        //Explode big rocket

                        if (jjObjects[i].state == STATE::EXPLODE && jjObjects[i].special == 13) {

                                switch (jjObjects[i].eventID) {

                                        case OBJECT::RFBULLET: BigRocketExplode(i, false); break;

                                        case OBJECT::RFBULLETPU: BigRocketExplode(i, true); break;

                                }

                                continue;

                        }

                }

                

        for (int i = 0; i < 32; i++)

                if (!boomerangfired[i]) {

                        speed[i] = cMaxSpeed;

                        returning[i] = false;

                        if (i == p.playerID)

                                p.noFire = false;

                } else boomerangfired[i] = false;

}

Remove the sqrt and abs function definitions.

To be clear, though, the point of this topic was asking whether J2O should fix broken scripts that are uploaded to J2O, not asking how to fix scripts.

Quote:

Originally Posted by Violet CLM (Post 495714)

Add types to the four arrays, like so:

Code:

array returning(32, false);

array boomerangfired(32, false);

array speed(32, cMaxSpeed);

array isfoly(32, false);

and remove the sqrt and abs function definitions altogether.

thanks so much!!
i tested it,
..and i was able to fix it!
now the script works again
.
.

Quote:

Originally Posted by Violet CLM (Post 495714)

To be clear, though, the point of this topic was asking whether J2O should fix broken scripts that are uploaded to J2O, not asking how to fix scripts.

i do vote for "yes"
J2O have to fix, broken scripts that are uploaded here
=
im absolutly sure, its also in the interrests of the autors, that there own scripts works fine. (with latest plus)
im sure they dont have anything against it
so i give my yes

100% yes. I think preserving people's work in a playable state is more important than erring on the side of a very unlikely scenario where an author would be angry that their work got a free bugfix.

I suppose we do allow people to upload screenshots for other people's levels, which is kind of like updating them for newer versions of J2O.

Response is positive so far, but I'm hesitant to commit J2O to a policy after only two votes.

I think authors should be asked first, and then only after a certain period if there is no response the script could be fixed, with a clear notice that it happened and a backup of the original file in the zip too.

Bloody_Body hasn't logged into J2O since 2022, so they wouldn't see a private message, but I suppose they do have an email on file.

How long would "a certain period" be?

Yes, if the author is MIA, J2O should reupload fixed versions of broken scripts. No, I will not elaborate.

Quote:

Originally Posted by Stijn (Post 495728)

+1

As for the amount of time, uhh, I suggest 3 months. That feels reasonable.

Okay, I've not seen any pushback to Slaz's 3 months idea, so I've emailed Bloody_Body and I'm in contact with Blackraptor. Are there any other broken scripts on J2O, besides Psychomondus and AGenSP10Year, that I don't know about?

Quote:

Originally Posted by Violet CLM (Post 495711)

What about (parts of) levels that never worked to begin with, even for reasons other than AngelScript?

This got no reply, so let's probably not worry about it. If your level never worked to begin with, maybe that's your fault, not J2O's.

The Putrid monkey strikes back episode is broken at the moment, the last level can't be finished and it has a start position somewhere near the end. Seems they tried to fix the end episode at some point for 1.23 and broke the level. I still have the original file, that seems to work fine. Might be worth replacing?

The script for A Generic Single Player Level II has been fixed to work with the current latest plus version (v6.6). Thanks for bringing this to my attention and apologies for the delay.

Woohoo! Now that you mention it, it has been a while since I've delved through those generic depths...

I've just learned that Tweedle Wheedle also has script errors, seemingly again from trying to XOR numbers by 0.5. I guess I could email Bloody_Body again, but given that I've gotten no reply yet from my last email two months ago, I wouldn't really anticipate any answer.

I've reuploaded Psychomondus with a working script. I'm going to email Bloody_Body again to let them know and to ask about Tweedle Wheedle, though this time, I'll probably only wait one month, since they're already known to be unresponsive.

(For editing the Psychomondus script, I redownloaded the version of JJ2+ that was current in July 2018 and used it to confirm that ^ 0.5 was treated as ^ 0, which did not change the number at all. While it seems likely that the script was intended to take the square roots of those numbers, that's not what it actually did, so I chose to preserve the original functionality over the original intent.)

I've fixed and reuploaded Tweedle Wheedle now too. Same logic: original functionality (not changing numbers) over original intent.

I'm reasonably confident it'll be possible to contact at least one of the creators of Putrid Monkey Strikes Back, unless anyone wants to argue that that's an overreach. In January 2001 they actually tried to release a patch for a couple of the episode levels--I'm not sure what ended up happening there, if the patch was (unsuccessfully?) applied to the original upload or what happened.

Newspaz gave me his blessing to reupload PMSB with the files from the January 2001 patch. I don't actually know what the difference is in level 1, but in level 7, the start position is now in the right spot and the End Area events have been restored.

If that's all the known broken things, we're in good shape!

Hi
i have a very importand question
.
- can i also add here a script, that lost his compatility?
(and would the cummunity of jazz2, so friendly to help me?, to make that script playable again?)
.
i have a old plus script, that lost his compatilitly...
its from my "hyper space 3" level..
there was a location, with the engine
if a player did touched the flame
then the player did got burned down, into "red particels"
the same effect that you can see by killing other players in instagib
.
can i post this script code here?
or do you want me, to post it in a other thread?
i only ask, i dont want to make here anything wrong..

The AngelScript requests thread would make sense, or just starting a new thread. If possible, though, I'd prefer to keep this one about whether J2O should reupload fixed versions of broken scripts [that were already on J2O to begin with].